Fixes issue #97 to have a clue in the logs when there is a syntax problem and raises Internal Server Error #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ternal Server Error to ease debugging
ThomasWaldmann
requested changes
Sep 17, 2024
| parser.format(self.formatter) | ||
| try: | ||
| parser.format(self.formatter) | ||
| except ValueError: |
There was a problem hiding this comment.
Hmm, is it only ValueError or do we also want to catch other exceptions here? Could also use Exception.
| key = u'' | ||
| keywords[key] = value | ||
| positional = trailing | ||
| except ValueError: |
There was a problem hiding this comment.
if you are trying to catch this for line 1510 only, the except ...: block should be moved to the line below there and the "no exception" other commands into an else: block.
| keywords[key] = value | ||
| positional = trailing | ||
| except ValueError: | ||
| logging.error('Poblem %s' item) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ease debugging in case of an Internal Server Error due to a case of problematic syntax such as
[[https://www.waze.com/en/live-map/directions/escola-tecnica-pandia-calogeras-r.-62-90-volta-redonda?place=w.207029799.2070297987.1827329|Waze|targethttps://ul.waze.com/ul?preview_venue_id=207029799.2070297987.1827329&navigate=yes&utm_campaign=default&utm_source=waze_website&utm_medium=lm_share_location="_blank"]]