Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add various missing German translations, consolidate and simplify existing ones #1547

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

wagner-intevation
Copy link
Contributor

Add some missing strings
Simplify a few translations
and consolidate the mixed translation of namespace: one occurrence of it was translated, others weren't. So translate all for consistency

@wagner-intevation wagner-intevation force-pushed the translate-de branch 3 times, most recently from 4fc289a to 73286b7 Compare October 9, 2023 13:01
@wagner-intevation wagner-intevation changed the title Add various missing German translations Add various missing German translations, consolidate and simplify existing ones Oct 9, 2023
@UlrichB22
Copy link
Collaborator

Hi Sebastian,
thanks for providing additional translations. Here are some typos or enhancements with line numbers:

  • 1350: ... kann, ItemID =
  • 1492: des Items
  • 1723: Prüfe den Namen!
  • 1753: Schlüssel (oder Key)
  • 1771: schreib mir
  • 2001: finden
  • 2035: Klicke Link 'Hervorheben' in den Item-Ansichten, um den reinen Text zu sehen.
  • 2769: Wort 'um' ist doppelt

What is your opinion about 'Abbestellen' instead of 'Deabonnieren'?

After updating and before commiting please run following command to create standard line-breaks:
python setup.py update_catalog -l de

The line breaks should then appear after about 120 characters. This prevents the lines from changing the next time someone wants to update the translations.

Add some missing strings
Simplify a few translations
and consolidate the mixed translation of namespace: one occurrence of it was translated, others weren't. So translate all for consistency
@wagner-intevation
Copy link
Contributor Author

1723: Prüfe den Namen!

I'm not sure what you mean here. The section of the file with this line is:

#: src/moin/macros/HighlighterList.py:21
msgid "File Patterns"
msgstr "Datei-Muster"

What is your opinion about 'Abbestellen' instead of 'Deabonnieren'?

I agree this is better, good suggestion.

After updating and before commiting please run following command to create standard line-breaks: python setup.py update_catalog -l de

Yes, I followed this as documented in the docs

@UlrichB22
Copy link
Collaborator

Now its line 1727, it should be something like:
msgstr "Icon wird nicht dargestellt, Prüfen Sie den Namen"

@UlrichB22
Copy link
Collaborator

Added the above mentioned line and fixed some line-breaks.

@UlrichB22 UlrichB22 merged commit 409d3f4 into moinwiki:master Oct 10, 2023
4 checks passed
@wagner-intevation
Copy link
Contributor Author

Now its line 1727, it should be something like: msgstr "Icon wird nicht dargestellt, Prüfen Sie den Namen"

The English string does not contain that phrase?

@UlrichB22
Copy link
Collaborator

It is fixed and merged already:

msgstr "Icon wird nicht dargestellt, prüfe den Namen"

@wagner-intevation
Copy link
Contributor Author

Oh, okay, I misunderstood the English text. I read "'verify name' is valid", i.e. 'verify name' as some label for an internal process or method, not as a prompt to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants