Attempting to add support for new Contacts API #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That new API looks pretty insane (as in inconsistent and wrong in many ways -_-) I understand it's still in beta. Currently I don't have much time to work on it, but I'll look at it when I have some time. Some VCR tests (failing or succeeding) would be appreciated. |
|
Yeah it definitely is not consistant with the rest of the API's. I'll let you know if I do anymore with this for now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I've taken a stab at adding support for the new Contacts API that Hubspot has now but they way their returned json is formatted is very different from the rest of the API's.
Here's what I've done so far if you want to take a look and see what you can do.
Let me know if you get anywhere with it. Thanks.