Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roc chart to gallery #1599

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Add roc chart to gallery #1599

merged 3 commits into from
Sep 29, 2023

Conversation

RossKen
Copy link
Contributor

@RossKen RossKen commented Sep 12, 2023

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

Give a brief description for the solution you have provided

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks or tutorial (if appropriate)
  • Added tests (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter

"??? note \"What the chart tooltip shows\"\n",
" ![](./img/roc_chart_from_labels_table_tooltip.png)\n",
"\n",
" The tooltip shows information based on the point on the curve that the user is hoverng over, including:\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick aside, should we adjust the truth_threshold chart label? I understand why it's been named as such, but it's not the clearest description.

Copy link
Contributor

@ThomasHepworth ThomasHepworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks.

@RossKen RossKen merged commit 64ec196 into master Sep 29, 2023
10 checks passed
@RossKen RossKen deleted the roc_gallery branch September 29, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants