implement a janitorclass to automatically format class attributes #1650
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Is your Pull Request linked to an existing Issue or Pull Request?
Follows on from #1642.
Give a brief description for the solution you have provided
Adds in a simple
JanitorClass
that automatically sets class attributes to upper case. This streamlines some of the SQLglot code and removes the need for a verbose try except clause to grab our quote identifiers.If you think this is over-engineering the solution, then I shall scrap it!
Just to note, this can also be done with metaclasses with some inheritance magic. However, as SQLglot already makes use of metaclasses, I've just implemented a wrapper class that manipulates how attributes are pulled.
PR Checklist