Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 1651 - comparison viewer bars sorted improperly #1652

Merged
merged 5 commits into from
Oct 18, 2023
Merged

Fix issue 1651 - comparison viewer bars sorted improperly #1652

merged 5 commits into from
Oct 18, 2023

Conversation

RobinL
Copy link
Member

@RobinL RobinL commented Oct 16, 2023

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

Closes #1651

@RobinL RobinL changed the title Issue 1651 (WIP) Issue 1651 Oct 16, 2023
@RobinL RobinL changed the title (WIP) Issue 1651 (WIP) Fix issue 1651 - comparison viewer bars sorted improperly Oct 16, 2023
@RobinL
Copy link
Member Author

RobinL commented Oct 16, 2023

Best to merge this first

At the moment it's built on top of #1639, once that's merged we can target master

@RobinL RobinL changed the title (WIP) Fix issue 1651 - comparison viewer bars sorted improperly (Don't merge until 1639 is merged) Fix issue 1651 - comparison viewer bars sorted improperly Oct 16, 2023
Base automatically changed from splink_vis_updates_to_source to master October 16, 2023 14:44
@RobinL RobinL changed the title (Don't merge until 1639 is merged) Fix issue 1651 - comparison viewer bars sorted improperly Fix issue 1651 - comparison viewer bars sorted improperly Oct 16, 2023
ADBond
ADBond approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@ADBond ADBond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@RobinL
Copy link
Member Author

RobinL commented Oct 18, 2023

Thanks v much!

@RobinL RobinL merged commit 24008da into master Oct 18, 2023
2 checks passed
@RobinL RobinL deleted the issue_1651 branch October 18, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADBond ADBond ADBond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: comparison_viewer_dashboard vectors are not synced with histogram
2 participants
@RobinL @ADBond