[WIP] Use fresh pipelines rather than linker pipeline #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinL
force-pushed
the
use_fresh_pipelines
branch
from
7349706
to
da158f0
Compare
RobinL
commented
Mar 16, 2024
| @@ -535,6 +535,17 @@ def _initialise_df_concat_with_tf(self, materialise=True): | |||
|
|
|||
| return nodes_with_tf | |||
|
|
|||
| def _enqueue_df_concat_with_tf(self, pipeline: SQLPipeline): | |||
There was a problem hiding this comment.
This is no good because it doesn't deal with the cache
This is really fiddly because either:
- You want to execute the pipeline, add it to the cache and return the dataframe
- Retrieve from the cache if exists
- Return a pipeilne with the right sqls enqueued
So there's not an easy version of this that uses a fresh sql pipeline. you can pass one in, but then uncear what to return
Another option would be to allow the pipeline to queue input dataframes, tha seems promising ?
There was a problem hiding this comment.
in that case, a fresh sql pipeline is passed in. If it's in the cache, then the pipeline is returned with it as an input dataframe queued up
if it's not in the cache either
- materialisation case: a pipeline is returned with it in the cache
- non-materialisation case: a pipeline is returned with sql enqueued
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP