Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Is your Pull Request linked to an existing Issue or Pull Request?
#1001
Give a brief description for the solution you have provided
Update: leaving as draft until more work done on applying graph metrics to linked justice data
Simple first version of chart for plotting cluster metrics (in this case cluster centralisation).
It is likely that this functionality will become more generic, e.g. generating plots for size, density and/or centralisation (
linker.cluster_centralisation_chart
->linker.cluster_metrics_charts
) so is currently non-public and unpolished.I find the current naming convention for functions in
charts.py
a bit confusing because they are the same as the linker methods which call them (and I wonder whether this is best practice anyway(?)) so I have gone for_build_cluster_centralisation_chart()
instead. If this naming choice makes more sense then maybe it can be adopted for the other charts as well, but happy to drop 'build' and follow suit if not.Ideas for subsequent PRs include:
Reprex for Splink 4
PR Checklist