Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Switch to ruff #2135

Closed
wants to merge 7 commits into from
Closed

(WIP) Switch to ruff #2135

wants to merge 7 commits into from

Conversation

RobinL
Copy link
Member

@RobinL RobinL commented Apr 5, 2024

Do we want the formatter to commit back, or just report on problems?

@ADBond
Copy link
Contributor

ADBond commented Apr 22, 2024

re: report/commit - I think I'm in favour of just having a pass/fail, rather than committing back changes. Been thinking about this for a while, and with autocommit:

  • fiddly to get it working with forks
  • confuses CI status on PRs if that's the final commit
  • end up with loads of noise commits - if I pushed a change that failed the lint, providing PR is in early stage I would prefer to amend my commits + repush. With the 'lint with black' type commit this is more of a pain, and probably wouldn't bother, so just more noise.

Don't feel super strongly, but think that would be my preference. Could potentially encourage devs to include a ruff --fix pre-commit hook to catch a bunch of stuff?

@RobinL
Copy link
Member Author

RobinL commented Apr 22, 2024

Yeah, agree. I find auto commit pretty annoying!

@RobinL RobinL closed this Apr 30, 2024
@RobinL RobinL mentioned this pull request Apr 30, 2024
@RobinL RobinL deleted the switch_to_ruff branch August 12, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants