-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add merchant registry helm charts #598
base: main
Are you sure you want to change the base?
feat: add merchant registry helm charts #598
Conversation
34ece5f
to
ff7b9f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just some minor changes.
Also, are there any services in these charts that need to be deployed as part of core Mojaloop deployment?
Thanks @oderayi and @tw-sithumyo .. Please hold off on the merge while iterating on these changes; And until all the image versions used are greater than v1.0.0 indicating that they're release / production quality |
hello @oderayi , thanks for thorough review, I made changes according to your suggestions. |
a8d077a
to
ac3e6d0
Compare
version has been bumped to 1.0.x. |
9a6f7ed
to
809edd3
Compare
spec: | ||
automountServiceAccountToken: false | ||
containers: | ||
- name: merchant-db |
Check warning
Code scanning / SonarCloud
Storage limits should be enforced Medium
Thanks @tw-sithumyo; Two items left from the sonar check, please review. |
Quality Gate failedFailed conditions |
Hello @elnyry-sam-k , the storaged limit related 2 issues has been resolved. |
Once this is ready, we'll have to change the "base" branch to "v16.0.0-rc-1" so that it can be tested with the v16 RC codebase and then shipped after passing the release criteria. |
No description provided.