Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: config override #630

Merged
merged 11 commits into from
Jun 7, 2024
Merged

feat: config override #630

merged 11 commits into from
Jun 7, 2024

Conversation

kalinkrustev
Copy link
Contributor

@kalinkrustev kalinkrustev commented May 27, 2024

What is going on here is that in the values one can specify something like this:

configOverride:
  .EVENT_SDKrc:
    # configuration overrides for event sdk
  .CLEDGrc:
    # configuration overrides for central ledger

Then these will be volume-mounted as files .EVENT_SDKrc and .CLEDGrc within the /opt/app dir, where they will be processed by the rc module.
The configuration properties will work as overrides on top of the default.json.
This is a way to apply individual changes to configuration properties in IAC, instead of copying the whole configuration from the default.json file.

@kalinkrustev kalinkrustev marked this pull request as draft May 27, 2024 18:31
@kalinkrustev kalinkrustev changed the title feat: performance optimization feat: config override Jun 4, 2024
@kalinkrustev kalinkrustev marked this pull request as ready for review June 4, 2024 13:39
Copy link
Contributor

@vijayg10 vijayg10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Do you want to add empty configOverride section with some comments in the values files?

@kalinkrustev
Copy link
Contributor Author

This looks good to me. Do you want to add empty configOverride section with some comments in the values files?

Added the section in 88aa64e

@kalinkrustev
Copy link
Contributor Author

@elnyry-sam-k are you OK with merging this to master?

There are a lot of changed files, but they all do the same for each chart:

  • add templates/config-override.yaml
  • mount in in the opt/apt folder

Copy link

sonarcloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@elnyry-sam-k elnyry-sam-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very powerful feature. Thanks @kalinkrustev

@kalinkrustev kalinkrustev merged commit 0220ba7 into main Jun 7, 2024
9 checks passed
@kalinkrustev kalinkrustev deleted the performance-optimization branch June 7, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't publish a snapshot for commits starting with 0
3 participants