-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: config override #630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Do you want to add empty configOverride section with some comments in the values files?
Added the section in 88aa64e |
@elnyry-sam-k are you OK with merging this to master? There are a lot of changed files, but they all do the same for each chart:
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very powerful feature. Thanks @kalinkrustev
What is going on here is that in the values one can specify something like this:
Then these will be volume-mounted as files
.EVENT_SDKrc
and.CLEDGrc
within the/opt/app
dir, where they will be processed by therc
module.The configuration properties will work as overrides on top of the
default.json
.This is a way to apply individual changes to configuration properties in IAC, instead of copying the whole configuration from the
default.json
file.