Draft: Fix platform handling #796
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urielsalis
approved these changes
Apr 21, 2023
|
Can we do a bulk change of Windows 10 - PC to Windows to reduce impact? |
|
This bulk change (or rather, rename) already happened. That's the issue - it's not mentioned in any of the changelogs, so the KeepPlatform module retrieves "Windows 10 - PC" as the correct platform, but the bug report is set to "Windows", so it tries to change "Windows" to "Windows 10 - PC" which obviously doesn't work. We'll probably need to add a special case to that module just for this reason. Also KeepPlatform probably will also need a platform whitelist similar to the other platform module so that it can only set platforms in that whitelist (for other old platforms that weren't renamed, e.g. "Gear VR"). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix intermittent error messages when trying to edit bug reports with an old platform that's no longer valid
Approach
Update the config to include the new platforms. Other necessary updates not implemented yet
Future work
Maybe refactor platform altogether, it's quite a mess
Checklist
and
docsfolder