Categorize messages in dropdown menu #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osfanbuff63
approved these changes
Jul 14, 2022
Marcono1234
reviewed
Jul 16, 2022
SPGoding
reviewed
Jul 18, 2022
SPGoding
reviewed
Jul 18, 2022
Marcono1234
reviewed
Jul 18, 2022
osfanbuff63
reviewed
Jul 18, 2022
Marcono1234
reviewed
Jul 18, 2022
|
I've made a change to allow undefined categories. It changes a bunch of things, including ordering categories alphabetically instead of in order of appearance. Please let me know if you'd like me to revert this change! |
Marcono1234
approved these changes
Jul 19, 2022
SPGoding
approved these changes
Jul 19, 2022
osfanbuff63
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change
Categories! I've added categories for duplicates, invalids, ARs, panels/notices, and miscellaneous items. Here's a sample.
Feedback is, of course, welcome, for both the code changes and the categories. This implements #97. Thank you! :)
How this affects future messages
This change requires a category field in every message definition. Additional categories can be configured within the
categoriessection.