-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify users of their resolved requests depending on a role selection #133
base: master
Are you sure you want to change the base?
Conversation
config/main.yml
Outdated
Select a reaction on this message if you want to be notified in DMs when requests are resolved after a certain amount of time. | ||
Default is no time requirement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Select a reaction on this message if you want to be notified in DMs when requests are resolved after a certain amount of time. | |
Default is no time requirement. | |
Select a reaction on this message if you want to only be notified about requests that are at least __ days old when they are resolved. | |
No reaction means there is no time requirement. |
I think the prompt I wrote above might be more clear. The prompt should tell the reader that the unit of time is days, and I think "no reaction" is clearer than "default".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that the description of each role/emoji specifies the amount of time that each emoji means, so specifying the unit of time in the prompt isn't as necessary as I had originally thought.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the "no reaction" message you suggested
I'm not sure whether this feature is really needed still. As I said previously I'd like to avoid adding extra complexity to MojiraBot at this point in time. I don't think there's reasonable demand for this feature, but I could be wrong. Also another merge is needed which would probably have some merge conflicts as well. I'd like to propose to postpone this feature. Please create an issue for it (seems like we don't have one already) so we can decide later if this is still something that we want or need. |
Resolves #228
Future work
I need IDs for the four roles (which I can't create) and two message IDs from #role-selection (same issue)