Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify users of their resolved requests depending on a role selection #133

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

chandler05
Copy link
Member

@chandler05 chandler05 commented Dec 1, 2020

Resolves #228

Future work

I need IDs for the four roles (which I can't create) and two message IDs from #role-selection (same issue)

config/main.yml Outdated
Comment on lines 89 to 90
Select a reaction on this message if you want to be notified in DMs when requests are resolved after a certain amount of time.
Default is no time requirement.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Select a reaction on this message if you want to be notified in DMs when requests are resolved after a certain amount of time.
Default is no time requirement.
Select a reaction on this message if you want to only be notified about requests that are at least __ days old when they are resolved.
No reaction means there is no time requirement.

I think the prompt I wrote above might be more clear. The prompt should tell the reader that the unit of time is days, and I think "no reaction" is clearer than "default".

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that the description of each role/emoji specifies the amount of time that each emoji means, so specifying the unit of time in the prompt isn't as necessary as I had originally thought.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the "no reaction" message you suggested

@chandler05 chandler05 changed the title Send DMs if a user's request is resolved and depending on a role selection Notify users of their resolved requests depending on a role selection Dec 1, 2020
@chandler05 chandler05 marked this pull request as draft December 2, 2020 16:45
@violine1101
Copy link
Member

I'm not sure whether this feature is really needed still. As I said previously I'd like to avoid adding extra complexity to MojiraBot at this point in time. I don't think there's reasonable demand for this feature, but I could be wrong.

Also another merge is needed which would probably have some merge conflicts as well.

I'd like to propose to postpone this feature. Please create an issue for it (seems like we don't have one already) so we can decide later if this is still something that we want or need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notify users when requests are resolved
3 participants