Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cifriendly-profile-bug #126

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ciis0
Copy link

@ciis0 ciis0 commented Jan 17, 2020

Supersedes #114
Fixes #103

@ciis0
Copy link
Author

ciis0 commented Jan 23, 2020

So, I getLog().info(...)-debugged some things and found that the issue arises in the following line:

Model originalModel = this.project.getOriginalModel().clone();

This "original model" already has some properties interpolated, for example ${basedir}, which is the original error that arose in the context I experienced this bug.

Therefore #getOriginalModel() does not seem to be suited for CI-friendly interpolation.

For cifriendlies, the following line might needs to work on a raw POM (FlattenMojo#getRawPom of #114), not originalModel:

return this.modelCiFriendlyInterpolator.interpolateModel( originalModel, this.project.getModel().getProjectDirectory(),
buildingRequest, problems );

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resolveCiFriendliesOnly interpolates more than just version and pom elements
1 participant