[conf][docs] Update test instructions #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianmeng
force-pushed
the
update-test-instruction
branch
from
a4dbce8
to
900a283
Compare
kianmeng
changed the title
cpjolicoeur
requested changes
Sep 10, 2024
README.md
Outdated
| @@ -83,7 +83,8 @@ end | |||
| First, you'll need to build the test database. | |||
|
|
|||
| ```elixir | |||
| MIX_ENV=test mix ecto.reset | |||
| docker-compose up | |||
There was a problem hiding this comment.
I'd prefer not to have this directly in the README like this as it implies this is a required step. I would be open to leaving a note here that speaks to "If you prefer to use docker, then do these steps..." type thing instead.
Add missing or incorrect step to bootstrap, build, and test the latest Postgres DB using compatible config with Docker-Compose or Podman Compose.
kianmeng
force-pushed
the
update-test-instruction
branch
from
900a283
to
7fe91d9
Compare
cpjolicoeur
approved these changes
Sep 11, 2024
|
🥳 🥳 🥳 🥳 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing or incorrect step to bootstrap, build, and test the latest Postgres DB using compatible config with Docker-Compose or Podman Compose.