Bump scrivener_ecto #483
Open
Bump scrivener_ecto #483
+5
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @samhamilton . Can you just re-run this once more so that the lockfile gets bumped to the latest 3.0.1 of scrivener_ecto? No reason not to lock to the latest at the current point in time |
|
@cpjolicoeur sure thing. Ran |
|
@samhamilton thanks for the updates. Some failing test runs though due to lock version issues with base ecto it seems. Also, please squash these commits into a single commit since they are all related and atomic in nature, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Saw that you took over the main scrivener_ecto repo but after a new release didn't bump Torch, not sure why not so here is a small pull to move things back to the main package.
Cheers
Sam