Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sync] Update to DashMap 6 #34

Merged
merged 3 commits into from
Sep 8, 2024
Merged

Conversation

GnomedDev
Copy link
Contributor

This is a breaking change due to the removal of the S generic parameter from EntryRef, but improves performance a ton apparently.

@tatsuya6502 tatsuya6502 self-requested a review September 8, 2024 10:29
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.84%. Comparing base (af40a12) to head (309fa89).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   91.90%   91.84%   -0.06%     
==========================================
  Files          23       23              
  Lines        4125     4097      -28     
==========================================
- Hits         3791     3763      -28     
  Misses        334      334              

Copy link
Contributor Author

@GnomedDev GnomedDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could have bumped MSRV up to 1.65 for dashmap 6, but since 1.76 came out 6 months ago this can remove the version restriction on triomphe.

@tatsuya6502 tatsuya6502 mentioned this pull request Sep 8, 2024
@tatsuya6502 tatsuya6502 added this to the v0.11.0 milestone Sep 8, 2024
@tatsuya6502 tatsuya6502 changed the base branch from main to v0.11.x September 8, 2024 15:08
@tatsuya6502 tatsuya6502 changed the base branch from v0.11.x to main September 8, 2024 15:09
Copy link
Member

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It looks good to me.

Just FYI, before releasing next version of mini-moka with this DashMap update, I will try to remove triomphe from the dependency and copy necessary codes from triomphe to mini-moka. (a relevant comment in a moka's issue). And then I will change the MSRV to 1.65. I am hoping to do it in next weekend.

If it takes too long, I will release the next version of mini-moka without removing triomphe. And its MSRV will be 1.76.

@tatsuya6502 tatsuya6502 merged commit ee2d64f into moka-rs:main Sep 8, 2024
11 of 12 checks passed
@GnomedDev GnomedDev deleted the dashmap-6 branch September 9, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants