feat(tw): init listbox component #4421
Conversation
|
See issue #4446 |
|
Need to add docs |
#4323) * Moved namespace creation to own method + enum * auto-formatting * simplified code * minor renames for more clarity * Split ColumnType mapping knowledge to separate class * auto-formatting * Adjusted for equals check * Fixed empty values check * Added email fix * Fix to copy old behavior * Added some notes * Created dedicated function for String methods to remove some initially needed castings. * Minor javadoc changes * Added a test that validates if all ColumnTypes are covered by a mapper * reverted an accidental change * auto-formatting * Split RDF row generating into separate functions * added baseURL validation to ColumnTypeRdfMapper * Fixed UUIDs being represented as Strings * concept version of testing all ColumnType conversions * Enabled previously failing test code * fixed a test * fixed a bug for datetime_array * Updated tests * Fixed ColumnType.FILE IRI * ColumnType.HEAD correct implementation/test * Fixed test to check correctly for REFBACK (non-query retrieval excludes REFBACK values) * Updated test comments * JSONB_ARRAY now not included in RDF output * fixed comment * Added some basic file metadata for ColumnType.FILE * Added missing drop schema in test * Added test to validate if refback is in RDF output * Fixed a bug regarding composite keys * Added missing drop schema in testing * auto-formatting * auto-formatting * Revert "auto-formatting" -> in class unrelated to this PR This reverts commit 4f5d0ce. * fixes AUTO_ID (uses Snowflake ID, not UUID)
* Fix CSV formatting * Add combined_network attribute * Typos * Clarify description * Add combined_network to demo data
|
No longer relevant |
I would propose that we merge and work on the form integration separately. It is unclear to me how the data flows into the component from parent components and it would be best to keep this PR focused.
This is listed in the issue #4446 |
davidruvolo51
requested review from
chinook25
and removed request for
chinook25 and
connoratrug
…ing, minor ts revisions
…nts and their inputs
There was a problem hiding this comment.
really nice to be able to test it in the form context
few things i noticed while testing in the form:
- it does not show the required field message
- it does not close the dropdown when i select a other field
- in de default theme the selected item background color is the same a the page background color, as a result popdown feels a bit broken / strange ?
- the dropdown does not close when i click outside the form
- the select value does not right align with the oder field values
as notes in de code comments, i suggest to move the data fetch outside of the form component and preferably triggered from the component that requires the data ( lazy), else we and up with large if else blocks the do al kind of data fetches for different component types.
|
|
|
||
| const refData = ref(); | ||
|
|
||
| onMounted(async () => { |
There was a problem hiding this comment.
why is this here? Innovative thought to do it here. For ref I moved this to the component so I can also define search behaviors. But we could move search behaviors to here assuming they are consistent across all lookup types (checkbox, radio, list, selectabletable, tree, etc)
| @focus="$emit('focus')" | ||
| @update:modelValue="$emit('update:modelValue', $event)" | ||
| @error="$emit('error', $event)" | ||
| ></LazyInputTextArea> | ||
| <LazyInputListbox |
There was a problem hiding this comment.
I think there will be multiple ways to display a ref so for now I would be okay to merge like this but there are already other PRs in the making for the other representation. As written above.
My proposal is to make explicit in emx metadata if you like to display a checkbox/radio/select/tree or table.
|
What are the main changes you did:
how to test:
todo: