-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable OIDC integration into preview #4440
base: master
Are you sure you want to change the base?
Conversation
Ah, login tests moeten nu via andere route natuurlijk, want oidc login leidt tot ander login gedrag. 1 van de devs vragen? |
imo enabling oicd by default on the preview is not a good idea. Login for testing stuf stakes much longer , and lost of test setups become way more complicated. I would suggest a single ( or small set ) test to test the oidc integration. |
I propose we can set OidcEneabled to 'false' but keep all env variables. Than oidc can be easily switched on in the preview using changes Harm just made to switch oidc on/off via the settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
as discussed, can we default oidc enabled to 'false' but then in the UI we can re-enable?
I expect we depend on #4372 to make this work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only set the settings on the preview server, but the preview server is not authorised in the IdP so it doesn't work yet. The IdP will return an unauthorised client message.
Quality Gate passedIssues Measures |
Sorry, didn't know about the Draft function. I am currently still working on the PR. |
What are the main changes you did:
how to test:
todo: