Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(catalogue): dcat semantics #4509

Merged
merged 19 commits into from
Dec 18, 2024
Merged

fix(catalogue): dcat semantics #4509

merged 19 commits into from
Dec 18, 2024

Conversation

BrendaHijmans
Copy link
Contributor

@BrendaHijmans BrendaHijmans commented Nov 21, 2024

What are the main changes you did

  • some changes in semantic annotations, to comply to HRICore 1.0 (and DCAT-AP3.0/NL) and towards HRICore 2.0 and HealthDCAT-AP.
  • see diff for changes

dct:issued and dct:modified are now generated from mg_insertedOn and mg_updatedOn. Upon new import of data (e.g. for migrations) these columns are set to the date of the new import.
need: pids (present in umcg research data catalogue)
need: RORs

add dcat:theme = Health (<skos:prefLabel xml:lang="en">Health</skos:prefLabel> / http://publications.europa.eu/resource/authority/data-theme/HEAL)
can dct:creator be dependent on Organisations.is lead organisation = true (should actually be Organisations.role = Data originator, but this is seldom filled out) > use compute field?
can dct:publisher be dependent on Organisations.is lead organisation = true > use compute field?

dct:license for dcat:Dataset is not filled out by any resource (Resources.license), can we use a place holder? HealthDCAT-AP is aiming for a mandatory url that at least needs to be filled out here and extra can be added as well.
same for dct:publisher for dcat:Catalog

if a Network is a Catalogue: get dcat:dataset from Resources table.

How to test

  • explain here what to do to test this (or point to unit tests)

Checklist

  • make ref naar Contact die als contacpoint moet worden opgegeven?

  • dcterms creator en publisher aparte velden die verwijzen naar Organisations

  • added/updated tests

  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@BrendaHijmans BrendaHijmans marked this pull request as ready for review November 21, 2024 10:23
Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ff bespreken: je hebt allerlei dingen weggehaald, die volgens mij gewoon goed zijn, waarom?

Enige wat nu nodig is dat we checken dat we WEL hebben wat er nodig is. Zoals die missende dct:publisher/creator.

Het is normaal niet problematisch als we meer hebben tenzij conflicterend met DCAT-health. Dwz, als de validators erover vallen.

data/_models/shared/Catalogues.csv Show resolved Hide resolved
data/_models/shared/Organisations.csv Outdated Show resolved Hide resolved
data/_models/shared/Organisations.csv Outdated Show resolved Hide resolved
data/_models/shared/Organisations.csv Outdated Show resolved Hide resolved
@@ -20,7 +20,7 @@ Resources,,external identifiers,refback,,,,External identifiers,,resource,,,Exte
Resources,,start year,int,,,,,,,,dcat:startDate,"The year when the resource started, e.g. when data or samples started to be collected or extracted, or when the resource was established","DataCatalogueFlat,EMA,RWEStaging,CohortsStaging,UMCGCohortsStaging,NetworksStaging"
Resources,,end year,int,,,,,,,,dcat:endDate,"The year the resource ceased, e.g. when data or sample collection was stopped","DataCatalogueFlat,EMA,RWEStaging,CohortsStaging,UMCGCohortsStaging,NetworksStaging"
Resources,,time span description,text,,,,,,,,,Description of time span,"DataCatalogueFlat,RWEStaging"
Resources,,contact email,,,,,,,,,dcat:contactPoint,Contact e-mail address ,"DataCatalogueFlat,CohortsStaging,RWEStaging,NetworksStaging,StudiesStaging,UMCGCohortsStaging"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dito

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dcat:contactPoint is structured in vcard:Kind, which in HRICore and DCAT-AP3.0 needs a name and email address. So I removed this annotation, but kept the one on personsInvolved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we want to drop 'contact email' and instead use the contacts?

data/_models/shared/Resources.csv Show resolved Hide resolved
@BrendaHijmans BrendaHijmans self-assigned this Nov 22, 2024
Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fix merge conflict but given our joint review last time that can be merged.

@@ -1,7 +1,7 @@
tableName,tableExtends,columnName,columnType,key,required,refSchema,refTable,refLink,refBack,validation,semantics,description,profiles,visible,computed
Catalogues,,,,,,,,,,,dcat:Catalog,A collection of resources within a network or consortium or about a common topic,DataCatalogueFlat,,
Catalogues,,name,,1,true,,,,,,dct:title,The name given to the catalogue,DataCatalogueFlat,,
Catalogues,,network,ref,1,true,,Resources,,,,,Network or consortium that publishes this catalogue,DataCatalogueFlat,,
Catalogues,,type,ontology,,true,CatalogueOntologies,CatalogueTypes,,,,dcat:theme,Type of catalogue,DataCatalogueFlat,,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what remove dcat:theme here? More tags not a problem?

data/_models/shared/Organisations.csv Outdated Show resolved Hide resolved
@BrendaHijmans BrendaHijmans merged commit ec6315d into master Dec 18, 2024
7 checks passed
@BrendaHijmans BrendaHijmans deleted the fix/dcat-semantics branch December 18, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants