-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(catalogue): dcat semantics #4509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ff bespreken: je hebt allerlei dingen weggehaald, die volgens mij gewoon goed zijn, waarom?
Enige wat nu nodig is dat we checken dat we WEL hebben wat er nodig is. Zoals die missende dct:publisher/creator.
Het is normaal niet problematisch als we meer hebben tenzij conflicterend met DCAT-health. Dwz, als de validators erover vallen.
data/_models/shared/Resources.csv
Outdated
@@ -20,7 +20,7 @@ Resources,,external identifiers,refback,,,,External identifiers,,resource,,,Exte | |||
Resources,,start year,int,,,,,,,,dcat:startDate,"The year when the resource started, e.g. when data or samples started to be collected or extracted, or when the resource was established","DataCatalogueFlat,EMA,RWEStaging,CohortsStaging,UMCGCohortsStaging,NetworksStaging" | |||
Resources,,end year,int,,,,,,,,dcat:endDate,"The year the resource ceased, e.g. when data or sample collection was stopped","DataCatalogueFlat,EMA,RWEStaging,CohortsStaging,UMCGCohortsStaging,NetworksStaging" | |||
Resources,,time span description,text,,,,,,,,,Description of time span,"DataCatalogueFlat,RWEStaging" | |||
Resources,,contact email,,,,,,,,,dcat:contactPoint,Contact e-mail address ,"DataCatalogueFlat,CohortsStaging,RWEStaging,NetworksStaging,StudiesStaging,UMCGCohortsStaging" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dito
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dcat:contactPoint is structured in vcard:Kind, which in HRICore and DCAT-AP3.0 needs a name and email address. So I removed this annotation, but kept the one on personsInvolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we want to drop 'contact email' and instead use the contacts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to fix merge conflict but given our joint review last time that can be merged.
@@ -1,7 +1,7 @@ | |||
tableName,tableExtends,columnName,columnType,key,required,refSchema,refTable,refLink,refBack,validation,semantics,description,profiles,visible,computed | |||
Catalogues,,,,,,,,,,,dcat:Catalog,A collection of resources within a network or consortium or about a common topic,DataCatalogueFlat,, | |||
Catalogues,,name,,1,true,,,,,,dct:title,The name given to the catalogue,DataCatalogueFlat,, | |||
Catalogues,,network,ref,1,true,,Resources,,,,,Network or consortium that publishes this catalogue,DataCatalogueFlat,, | |||
Catalogues,,type,ontology,,true,CatalogueOntologies,CatalogueTypes,,,,dcat:theme,Type of catalogue,DataCatalogueFlat,, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what remove dcat:theme here? More tags not a problem?
Quality Gate passedIssues Measures |
What are the main changes you did
How to test
Checklist
make ref naar Contact die als contacpoint moet worden opgegeven?
dcterms creator en publisher aparte velden die verwijzen naar Organisations
added/updated tests
added/updated testplan to include a test for this fix, including ref to bug using # notation