Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unmask dxt, dxu, dyt, dyu, dxtn, dyte output #376

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aekiss
Copy link
Collaborator

@aekiss aekiss commented Feb 6, 2023

closes #375

@russfiedler
Copy link
Collaborator

@aekiss I've had a think about this and I don't think I can endorse this as it stands. It's a change specifically introduced for the benefit of a particular piece of post processing software and you would have to prove that it's not going to break somebody else's software that relies on the current version. Its' a bad habit to get into. I suggest making it a conditional compile for ACCESS or ACCESS-OM only.

@aekiss
Copy link
Collaborator Author

aekiss commented Feb 9, 2023

OK that's fair enough, I wasn't thinking of the bigger picture. It's hard to imagine anybody needing land masking in these grid fields, but I take your point. I won't bother with conditional compilation - people can use this branch from my fork if they ever need this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save all grid variables unmasked
2 participants