-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logs): Loki integration #108
Changes from all commits
f0ab418
40eecdb
bea8325
cff758e
4c09e34
7a029e4
5e38a0b
158b075
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,8 +7,6 @@ use std::{ | |
time::Duration, | ||
}; | ||
|
||
use tracing::warn; | ||
|
||
use self::tps::TpsMetric; | ||
use crate::state::GlobalState; | ||
|
||
|
@@ -47,8 +45,7 @@ pub fn init(state: Arc<GlobalState>) { | |
.await | ||
{ | ||
Ok(response) => response, | ||
Err(e) => { | ||
warn!("failed to scrape latest metrics: {e}"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We no longer want this warning? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can re-add once we have something that checks if the node is actually running. At the moment it is always spam |
||
Err(_e) => { | ||
break 'metrics Default::default(); | ||
} | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might cause a panic. Could happen when we run the node and it delegates a tokio task to this thread, but it already has a runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about how to deal with this... Might switch to
futures::executor::block_on