Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/deprecate cargo make #262

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Refactor/deprecate cargo make #262

merged 2 commits into from
Sep 9, 2024

Conversation

gluax
Copy link
Contributor

@gluax gluax commented Sep 8, 2024

Motivation

To simplify tooling in the repo.

Explanation of Changes

cargo-make -> cargo xtask

Testing

Commands work.

Related PRs and Issues

Closes #260

@gluax gluax added the refactor code refactoring label Sep 8, 2024
@gluax gluax requested a review from Meshiest September 8, 2024 23:48
@gluax gluax self-assigned this Sep 8, 2024
Copy link
Contributor

@Meshiest Meshiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably needs documentation for how to run the new builder


[profile.release-big]
inherits = "release"
codegen-units = 16
incremental = true
lto = "thin"
opt-level = 1
panic = "unwind"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what this change does

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default behaviour I belive, but I moved it to the release profile, since both small and big specified it, might as well have them inherit it.

Base automatically changed from feat-reliable-cannon to main September 9, 2024 19:47
@gluax gluax merged commit 719bf84 into main Sep 9, 2024
2 checks passed
@gluax gluax deleted the refactor/deprecate-cargo-make branch September 9, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

♻️ Deprecate cargo-make for xtask
2 participants