Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metrics): Prometheus integration #92

Merged
merged 13 commits into from
Apr 8, 2024
Merged

feat(metrics): Prometheus integration #92

merged 13 commits into from
Apr 8, 2024

Conversation

voximity
Copy link
Collaborator

@voximity voximity commented Apr 2, 2024 •
edited
Loading

Tasks:

  • Prometheus/Grafana boilerplate
  • HTTP service discovery for agents that are running nodes in real-time
  • Research: metrics cleanup - when to evict old metrics, use standard retention?
  • Properly serve agent metrics IP:port for Prometheus container (currently hard-coded to use host.docker.internal)
  • Outcomes integration: on this PR or another PR?

@voximity voximity marked this pull request as draft April 2, 2024 23:09
@voximity
Copy link
Collaborator Author

voximity commented Apr 2, 2024

Note that the source branch name feat-prometheus-pushgateway is no longer relevant because we decided against using Pushgateway and instead are using httpsd

@voximity voximity self-assigned this Apr 2, 2024
@voximity voximity added this to the Monadic.us MVP Testing Infra milestone Apr 2, 2024
@voximity voximity requested review from Meshiest and gluax April 6, 2024 03:47
@voximity voximity marked this pull request as ready for review April 6, 2024 03:47
gluax
gluax approved these changes Apr 6, 2024
View reviewed changes
crates/snops/src/cli.rs Show resolved Hide resolved
crates/snops/src/env/timeline.rs Outdated Show resolved Hide resolved
crates/snops/src/schema/outcomes.rs Outdated Show resolved Hide resolved
crates/snops/src/server/mod.rs Show resolved Hide resolved
crates/snops/src/server/mod.rs Outdated Show resolved Hide resolved
Meshiest
Meshiest reviewed Apr 7, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@voximity voximity requested a review from gluax April 8, 2024 16:21
@voximity voximity merged commit ce18844 into main Apr 8, 2024
2 checks passed
@gluax gluax mentioned this pull request Apr 9, 2024
Closed
@Meshiest Meshiest deleted the feat-prometheus-pushgateway branch April 21, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gluax gluax gluax approved these changes

@Meshiest Meshiest Meshiest approved these changes

Assignees

@voximity voximity

Labels
None yet
Projects
None yet
Milestone
Monadic.us MVP Testing Infra
Development

Successfully merging this pull request may close these issues.
3 participants
@voximity @Meshiest @gluax