Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: snot errors #93

Merged
merged 14 commits into from
Apr 3, 2024
Merged

Feat: snot errors #93

merged 14 commits into from
Apr 3, 2024

Conversation

gluax
Copy link
Contributor

@gluax gluax commented Apr 2, 2024

Adds proper errors for snot.
Also puts the error into logging if they exist.

Example log with an error:
image

And here's the same error from the cli:
image

@gluax gluax requested review from Meshiest and voximity April 2, 2024 23:12
@gluax gluax self-assigned this Apr 2, 2024
Copy link
Collaborator

@voximity voximity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small, mostly irrelevant comments

crates/snot-common/src/rpc/error.rs Outdated Show resolved Hide resolved
crates/snot/src/cannon/error.rs Outdated Show resolved Hide resolved
crates/snot/src/cannon/file.rs Outdated Show resolved Hide resolved
crates/snot/src/cannon/file.rs Outdated Show resolved Hide resolved
crates/snot/src/env/error.rs Outdated Show resolved Hide resolved
@voximity voximity merged commit a5d0fea into main Apr 3, 2024
0 of 2 checks passed
@Meshiest Meshiest deleted the feat/snot-errors branch April 21, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants