Implement XEP-0157: Contact Addresses for XMPP Services #1238
Conversation
lissine0
commented
Sep 15, 2024
lissine0
commented
| resultDictionary[fieldName] = addresses; | ||
| } | ||
| } | ||
| account.connectionProperties.serverContactAddresses = resultDictionary; |
There was a problem hiding this comment.
Is this fine? or is [ copy] / [ mutableCopy] more appropriate?
There was a problem hiding this comment.
having this non-mutable would be better...
There was a problem hiding this comment.
So do you mean just
account.connectionProperties.serverContactAddresses = [resultDictionary copy];
Or do you also mean changing MLXMPPConnection.serverContactAddresses's type from NSMutableDictionary* to NSDictionary*
There was a problem hiding this comment.
both, copy and change to NSDictionary
| //get the server's contact addresses (XEP-0157) | ||
| XMPPDataForm* dataForm = [iqNode findFirst:@"{http://jabber.org/protocol/disco#info}query/\\{http://jabber.org/network/serverinfo}result\\"]; | ||
| NSMutableDictionary* resultDictionary = [NSMutableDictionary dictionary]; | ||
| NSString* fieldName; |
There was a problem hiding this comment.
Side question: would it be more efficient if NSMutableString is used here?
There was a problem hiding this comment.
use NSMutableString where?
There was a problem hiding this comment.
NSMutableString* fieldName; instead of NSString* fieldName;
There was a problem hiding this comment.
but the field name isn't mutated at all, why use NSMutableString? You'd even have to mutably copy the NSString over into an NSMutableString as opposed to just using the NSString directly as is.
| XMPPDataForm* dataForm = [iqNode findFirst:@"{http://jabber.org/protocol/disco#info}query/\\{http://jabber.org/network/serverinfo}result\\"]; | ||
| NSMutableDictionary* resultDictionary = [NSMutableDictionary dictionary]; | ||
| NSString* fieldName; | ||
| for (MLXMLNode* field in dataForm.children) |
There was a problem hiding this comment.
Read the data-forms part of my xml query article and check out the dictionary and array interfaces in XMPPDataForm.h as well.
There was a problem hiding this comment.
This still needs to be addressed...
| resultDictionary[fieldName] = addresses; | ||
| } | ||
| } | ||
| account.connectionProperties.serverContactAddresses = resultDictionary; |
There was a problem hiding this comment.
having this non-mutable would be better...
| //get the server's contact addresses (XEP-0157) | ||
| XMPPDataForm* dataForm = [iqNode findFirst:@"{http://jabber.org/protocol/disco#info}query/\\{http://jabber.org/network/serverinfo}result\\"]; | ||
| NSMutableDictionary* resultDictionary = [NSMutableDictionary dictionary]; | ||
| NSString* fieldName; |
There was a problem hiding this comment.
use NSMutableString where?
|
quick heads up: this is still missing the dataforms rewrite to be mergeable... |
