Properly initialize a contact's blocked state #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lissine0
force-pushed
the
blocked-contact-details
branch
2 times, most recently
from
bf6dbe3
to
fd39c9a
Compare
|
This still has a bug: the dummy contact could still be blocked (whole domain or by bare jid), even if it is a dummy contact not being in our buddylist. Your code does not handle that correctly. |
lissine0
force-pushed
the
blocked-contact-details
branch
from
fd39c9a
to
3aaf40f
Compare
tmolitor-stud-tu
requested changes
Oct 9, 2024
| @@ -233,7 +228,12 @@ +(MLContact*) createContactFromDatabaseWithJid:(NSString*) jid andAccountID:(NSN | |||
| }]; | |||
| } | |||
| else | |||
| return [self contactFromDictionary:contactDict]; | |||
| { | |||
There was a problem hiding this comment.
the curly braces are not needed here, because this is a single instruction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1254
The changes I force-pushed are not strictly necessary. But I think they make it clearer that we don't expect a
@"blocked"key in the dictionary we get from DataLayerThis works because an uninitialized BOOL is set to false by default.