Dockerfile: Add Dockerfile and respective workflow #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FriedrichAltheide
requested changes
Sep 10, 2023
|
Thank you very much for the PR. Would you please address the two minor change requests? @tmolitor-stud-tu Could you please have a quick look as well? |
FriedrichAltheide
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from @weiss communication to you.
The workflow only builds the image without publishing it to the github registry
monal-im/fpush.If you want to publish them, just uncomment the last step in the respective workflow file. This will build and push an image based on the latest commit from this repository.
If you want a different name for the subdir, just let me know.
Cheers,
Saarko
P.S. The Dockerfile builds fpush with statically linked musl-libc packaged into google distroless images to have the smallest image possible as well as following best practices in terms of attack surface, running unprivileged, etc.