QC checks #385
Draft
QC checks #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hrshdhgd @souzadevinicius We want to actually use a proper testing framework and setup as in #319, but we want to discuss setting that up in a standard, approved way before merging it, so we're getting the ball rolling now with some QC that involve simply running scripts. |
matentzn
reviewed
Dec 11, 2023
There was a problem hiding this comment.
We need to discuss this in a call, as there are two architectural questions attached:
- All mondo related python code should be in mondolib so it gets the same code quality practices associated and shared code can be levaraged
- IMO the check you have here is Mondo-level, not Mondo-ingest level, so there is a question of where it should be deployed.
joeflack4
commented
Dec 29, 2023
tests/check_dupe_exact_mappings.py
Outdated
| @@ -0,0 +1,81 @@ | |||
| """Report duplciate exact mappings in mondo.sssom.tsv""" | |||
There was a problem hiding this comment.
Report duplicate exact mappings in mondo.sssom.tsv
One of the QC checks.
| @@ -0,0 +1,90 @@ | |||
| """Checks that SSSOM is in sync with Mondo by ensuring that all SSSOM doesn't have any novel IDs.""" | |||
There was a problem hiding this comment.
Check SSSOM and ontology in sync
One of the QC checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
QC checks
Addresses
mondo.owl&mondo.sssom.tsvdiffer #384Related
mondo.sssom.tsvMultiple exact matches within source #368