Docs: config/context.json
#470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update: add-new-source.md with instructions on updating this file.
joeflack4
force-pushed
the
docs-context-json
branch
from
6f72de9
to
dcaefd7
Compare
joeflack4
commented
Mar 12, 2024
| @@ -25,6 +25,9 @@ Prefixes need to be entered in the following places in the yml: | |||
| ### 2.3. `config/prefixes.csv` | |||
| Add prefixes. | |||
|
|
|||
| ### 2.4. `config/context.json` | |||
joeflack4
commented
Mar 12, 2024
| @@ -25,6 +25,9 @@ Prefixes need to be entered in the following places in the yml: | |||
| ### 2.3. `config/prefixes.csv` | |||
| Add prefixes. | |||
|
|
|||
| ### 2.4. `config/context.json` | |||
There was a problem hiding this comment.
Related issue(s)
I think this is a file that probably should be programmatically generated. So I:
- Updated
Converterexporters mondolib#8 w/context.jsonas new entry and updated plan, which will ideally follow: - Created Exporters to support Monarch use cases biopragmatics/curies#106, in response to Charlie also agreeing that
curiesis a good place for this solution.
matentzn
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updates documentation concerning
context.jsonneeding to be edited when making a new source.Updates
Pre-merge checklist
Documentation
Was the documentation added/updated under
docs/?QC
Was the full pipeline run before submitting this PR using
sh run.sh make build-mondo-ingeston this branch (afterdocker pull obolibrary/odkfull:dev), and no errors occurred?New Packages
Were any new Python packages added?
Were any other non-Python packages added?
PR Review and Conversations Resolved
Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?