-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combined property-map.sssom.tsv
#500
Conversation
- There have been 2 property map TSV files used by robot rename. However, we are now utilizing the --allow-duplicates flag, which allows us to consolidate them into 1 file. - Delete: one of the property map files - Rename: the other of the files - Update: components goals to utilize the new/updated file - Update: Docs regarding this aspect of adding a new source
4057311
to
62e8491
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change very much but if you merge into dev before testing the pipeline, you may not be able to separate the resulting problems from other code merged into dev. This is a possibly impactful change (hopefully not)!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good with these changes and the data PR
Related to:
config/*property-map*.sssom.tsv
s #482--allow-duplicate-entities
as option in ROBOT rename ontodev/robot#1195Data PR:
property-map.sssom.tsv
- data files #505Overview
There have been 2 property map TSV files used by robot rename. However, we are now utilizing the
--allow-duplicates
flag, which allows us to consolidate them into 1 file.Pre-merge checklist
Documentation
Was the documentation added/updated under
docs/
?QC
Was the full pipeline run before submitting this PR using
sh run.sh make build-mondo-ingest
on this branch (afterdocker pull obolibrary/odkfull:dev
), and no errors occurred?New Packages
Were any new Python packages added?
Were any other non-Python packages added?
PR Review and Conversations Resolved
Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?
Changes