Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined property-map.sssom.tsv #500

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Combined property-map.sssom.tsv #500

merged 1 commit into from
Apr 30, 2024

Conversation

joeflack4
Copy link
Contributor

@joeflack4 joeflack4 commented Apr 28, 2024

Related to:

Data PR:

Overview

There have been 2 property map TSV files used by robot rename. However, we are now utilizing the --allow-duplicates flag, which allows us to consolidate them into 1 file.

Pre-merge checklist

Documentation

Was the documentation added/updated under docs/?

  • Yes
  • No, updates to the docs were not necessary after careful consideration

QC

Was the full pipeline run before submitting this PR using sh run.sh make build-mondo-ingest on this branch (after
docker pull obolibrary/odkfull:dev), and no errors occurred?

  • Yes
  • No, there are no functional (code-related) changes to the pipeline in the PR, so no re-run is necessary

New Packages

Were any new Python packages added?

Were any other non-Python packages added?

PR Review and Conversations Resolved

Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?

  • Yes

Changes

Consolidate property maps
- There have been 2 property map TSV files used by robot rename. However, we are now utilizing the --allow-duplicates flag, which allows us to consolidate them into 1 file.
- Delete: one of the property map files
- Rename: the other of the files
- Update: components goals to utilize the new/updated file
- Update: Docs regarding this aspect of adding a new source

@joeflack4 joeflack4 marked this pull request as draft April 28, 2024 05:07
@joeflack4 joeflack4 self-assigned this Apr 28, 2024
- There have been 2 property map TSV files used by robot rename. However, we are now utilizing the --allow-duplicates flag, which allows us to consolidate them into 1 file.
- Delete: one of the property map files
- Rename: the other of the files
- Update: components goals to utilize the new/updated file
- Update: Docs regarding this aspect of adding a new source
@joeflack4 joeflack4 marked this pull request as ready for review April 28, 2024 05:34
Copy link
Member

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change very much but if you merge into dev before testing the pipeline, you may not be able to separate the resulting problems from other code merged into dev. This is a possibly impactful change (hopefully not)!

@joeflack4 joeflack4 changed the base branch from main to develop April 29, 2024 03:42
Copy link
Contributor

@twhetzel twhetzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good with these changes and the data PR

docs/developer/add-new-source.md Show resolved Hide resolved
src/ontology/mondo-ingest.Makefile Show resolved Hide resolved
@joeflack4 joeflack4 merged commit be96a5f into develop Apr 30, 2024
@joeflack4 joeflack4 deleted the prop-map-update branch April 30, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants