-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the source of subclass sync to a merged version of edit and owl #607
base: main
Are you sure you want to change the base?
Conversation
To avoid the case that we include non-redundant subclass of links in Mondo, we mondo-edit needs to be the source for subclass sync, not mondo.owl. Here the source is swapped.
$(ROBOT) convert -i $(TMPDIR)/mondo/src/ontology/mondo-edit.obo -o $@ | ||
|
||
$(TMPDIR)/mondo-edit-mondo-owl-merged.owl: $(TMPDIR)/mondo-edit.owl $(TMPDIR)/mondo.owl | ||
$(ROBOT) merge -i $(TMPDIR)/mondo-edit.owl -i $(TMPDIR)/mondo.owl convert -o $@ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see, you merged them, not pass both as inputs. That makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a dream last night...
Haha
RG may, all by itself, remove the red subclass axiom in the figure below, rendering the change in this PR ineffectual
Mmm I see.
In my view, nothing bad will come of this change
Only negative is extra build time. Not a huge problem, but more a problem now than before, given how frequently we run them.
but we need to check manually, later down the line
Hmm, we can't check now?
Wouldn't we expect to see an increased number of new subclass relations in the -added
template, with this change?
Edit: Hmm, I checked doid.subclass.added.robot.tsv
in the build for this PR (#608), and compared it to another recent build (#606), and it had the same number of added subclass relations.
GH issue?: If we can't check it now for whatever reason, we should make an issue to check on this later; that redundant ancestor subclass relations/axioms are being added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only negative is extra build time
I think the extra build time is not so bad as the only redundant step is the robot merge step, which is fast (less than 8 seconds).
Hmm, I checked doid.subclass.added.robot.tsv in the build for this PR (#608), and compared it to another recent build (#606), and it had the same number of added subclass relations.
Thank you for checking that. In this case, lets just hold of on this PR for now and go ahead with what we previously had. Relieves the pressure a bit. I will
- Set this PR to draft
- Update the OP with the result of your investigation
- Schedule the PR for total closing in 2 months if we determine it is actually not needed.
I had a dream last night that this might not be necessary because of the way that semsql works. I dont know exactly what semsql does though, and now that Chris is gone it may be not possible to find out.
Here my dream:
In my view, nothing bad will come of this change, but we need to check manually, later down the line, if subclass assertions in mondo-edit.owl do not get support, even though it exists. We can stem that in a second round I think
Overview
This PR:
Pre-merge checklist
Documentation
Was the documentation added/updated under
docs/
?QC
Was the full pipeline run before submitting this PR using
sh run.sh make build-mondo-ingest
on this branch (afterdocker pull obolibrary/odkfull:dev
), and no errors occurred?New Packages
Were any new Python packages added?
Were any other non-Python packages added?
PR Review and Conversations Resolved
Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?
Sub-tasks
As @joeflack4 determine in his comment this PR may, after all, be redundant. We need to figure out the following: