Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE - Docs goals updates - build #654

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

DO NOT MERGE - Docs goals updates - build #654

wants to merge 3 commits into from

Conversation

joeflack4
Copy link
Contributor

@joeflack4
Docs goals updates
0bb297a 
- Various misc issues I noticed with docs related goals.
@joeflack4 joeflack4 self-assigned this Sep 14, 2024
@joeflack4 joeflack4 added the build Mostly for build PRs: when changes only to data files post `build-mondo-ingest`; no code changes label Sep 14, 2024
@joeflack4 joeflack4 mentioned this pull request Sep 14, 2024
Merged
9 tasks
@joeflack4 joeflack4 marked this pull request as draft September 14, 2024 21:27
joeflack4
joeflack4 commented Sep 14, 2024
View reviewed changes
Copy link
Contributor Author

@joeflack4 joeflack4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Since these are just docs changes, I'm mainly just wanting to make sure the build passes, and that the docs files are still getting built properly, and that appears so.

Other diffs also consistent w/ what I've seen in recent builds for various sources.

Base automatically changed from docs-goals-updates to develop September 21, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twhetzel twhetzel Awaiting requested review from twhetzel

Assignees

@joeflack4 joeflack4

Labels
build Mostly for build PRs: when changes only to data files post `build-mondo-ingest`; no code changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joeflack4