Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data build files for Week 1 of Mondo Release Cycle #718

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

twhetzel
Copy link
Contributor

@twhetzel twhetzel commented Dec 6, 2024

Resolves #ISSUE(s).

Overview

This PR:
Data build files for Week 1 of Mondo Release Cycle SOP

Pre-merge checklist

Documentation

Was the documentation added/updated under docs/?

  • Yes
  • No, updates to the docs were not necessary after careful consideration

QC

Was the full pipeline run before submitting this PR using sh run.sh make build-mondo-ingest on this branch (after
docker pull obolibrary/odkfull:dev), and no errors occurred?

  • Yes
  • No, there are no functional (code-related) changes to the pipeline in the PR, so no re-run is necessary

New Packages

Were any new Python packages added?

Were any other non-Python packages added?

PR Review and Conversations Resolved

Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?

  • Yes

@twhetzel twhetzel added the build Mostly for build PRs: when changes only to data files post `build-mondo-ingest`; no code changes label Dec 6, 2024
@twhetzel twhetzel requested a review from matentzn December 6, 2024 20:24
@twhetzel twhetzel self-assigned this Dec 6, 2024
@twhetzel twhetzel requested a review from joeflack4 December 6, 2024 20:25
Copy link
Member

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - a lot of diff, and next time (after EMC has run in Mondo) we should make sure that the diff is considerably smaller. A lot of diff though because of updated ORDO which is fine.

@twhetzel twhetzel merged commit f7a4424 into main Dec 9, 2024
@twhetzel twhetzel deleted the _main_data-build-6Dec2024 branch December 9, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Mostly for build PRs: when changes only to data files post `build-mondo-ingest`; no code changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants