-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synonym Sync - Redundant whitespace - mini build #739
base: synonym-strip-mini-build-base
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -4038,7 +4038,6 @@ MONDO:0010517 ciliary dyskinesia, primary, 36, X-linked oio:hasExactSynonym X-l | |||
MONDO:0010517 ciliary dyskinesia, primary, 36, X-linked oio:hasExactSynonym primary ciliary dyskinesia 36 DOID:0111850 primary ciliary dyskinesia 36 primary ciliary dyskinesia 36 DOID:0111850 | |||
MONDO:0010521 amelogenesis imperfecta type 1E oio:hasExactSynonym amelogenesis imperfecta type 1E DOID:0110058 amelogenesis imperfecta type 1E amelogenesis imperfecta type 1E DOID:0110058 | |||
MONDO:0010522 X-linked amelogenesis imperfecta hypoplastic/hypomaturation 2 oio:hasExactSynonym X-linked amelogenesis imperfecta hypoplastic/hypomaturation 2 DOID:0110059 X-linked amelogenesis imperfecta hypoplastic/hypomaturation 2 X-linked amelogenesis imperfecta hypoplastic/hypomaturation 2 DOID:0110059 | |||
MONDO:0010522 X-linked amelogenesis imperfecta hypoplastic/hypomaturation 2 oio:hasExactSynonym amelogenesis imperfecta type IE X-linked 2 DOID:0110059 X-linked amelogenesis imperfecta hypoplastic/hypomaturation 2 amelogenesis imperfecta type IE X-linked 2 DOID:0110059 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-added
--> -confirmed
On MONDO:0010522 amelogenesis imperfecta type IE X-linked 2 exists, but DOID:0110059 had 2 spaces between "imperfecta" and "type". Now, instead of this showing up as an -added
synonym, it is able to join on the existing Mondo synonym, so this entry now appears in -confirmed
intead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing for Ohdo syndrome, SBBYS variant, which is the only other removal in this DO file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One example of this in ORDO is Partial trisomy of chromosome Xq.
MONDO:0008675 Freeman-Sheldon syndrome oio:hasExactSynonym distal arthrogryposis type 2A distal arthrogryposis type 2A distal arthrogryposis type 2a DOID:0111605 distal arthrogryposis type 2A distal arthrogryposis type 2A DOID:0111605 | ||
MONDO:0008675 Freeman-Sheldon syndrome oio:hasExactSynonym distal arthrogryposis type 2A DOID:0111605 distal arthrogryposis type 2A distal arthrogryposis type 2A DOID:0111605 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many (most?) diffs are spurious
This diff is not caused by the changes in this PR (#738). This is an example of a diff that is caused because of duplicate rows (sorting isn't set up to account for that), which results in some rows being shifted up or down a little bit.
Fixed in #720. Reviewing these synonym sync diffs will be a lot easier once that's merged.
@@ -148,7 +148,7 @@ MONDO:0000680 astereognosia oio:hasExactSynonym tactile agnosia icd11.foundat | |||
MONDO:0000680 astereognosia oio:hasExactSynonym tactile amnesia icd11.foundation:756147896 Astereognosia tactile amnesia icd11.foundation:756147896 | |||
MONDO:0000687 diffuse alopecia areata oio:hasExactSynonym Diffuse alopecia areata icd11.foundation:666274267 Diffuse alopecia areata Diffuse alopecia areata icd11.foundation:666274267 | |||
MONDO:0000690 body dysmorphic disorder oio:hasExactSynonym Body dysmorphic disorder icd11.foundation:731724655 Body dysmorphic disorder Body dysmorphic disorder icd11.foundation:731724655 | |||
MONDO:0000698 gamma-amino butyric acid metabolism disorder oio:hasExactSynonym Disorders of GABA - [gamma aminobutyric acid] metabolism icd11.foundation:1811657969 Disorders of gamma aminobutyric acid metabolism Disorders of GABA - [gamma aminobutyric acid] metabolism icd11.foundation:1811657969 | |||
MONDO:0000698 gamma-amino butyric acid metabolism disorder oio:hasExactSynonym Disorders of GABA - [gamma aminobutyric acid] metabolism icd11.foundation:1811657969 Disorders of gamma aminobutyric acid metabolism Disorders of GABA - [gamma aminobutyric acid] metabolism icd11.foundation:1811657969 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified -added
entry
An extra space was removed from Disorders of GABA - [gamma aminobutyric acid] metabolism. This synonym doesn't yet exist in Mondo. If it did, this would be an example of an -added
entry being moved into -confirmed
. But since it doesn't exist in Mondo, the result is simply a modification of this row in-situ; the redundant space is removed.
There appear to be many such cases of this in icd11foundation
.
75fcd52
to
bbf343c
Compare
88747dc
to
f351ac3
Compare
- Update: Re-ran combined file. For some reason, it did not seem to run the first time correctly.
bbf343c
to
c939a97
Compare
Mini build for:
This was run back to back and shows just the output changes as a result of code changes.