Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QC check to look for excluded subclassof axioms which are asserted #8291

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

matentzn
Copy link
Member

@matentzn matentzn commented Oct 30, 2024

Fixes #8290

This tests a case where we said, deliberately:

This subclass axiom should not exist, but it turns out, it does!

There are quite a few cases like this; good call to look for that check, I would have thought that existed!

… are asserted

This tests a case where we said, deliberately:

This subclass axiom should not exist, but it turns out, it does!
@matentzn matentzn requested a review from twhetzel as a code owner October 30, 2024 12:33
Copy link
Collaborator

@twhetzel twhetzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queries looks good - thanks Nico!

I will ask if there is another curator who can review the QC errors now caught by this check.

@twhetzel twhetzel self-assigned this Nov 6, 2024
@twhetzel twhetzel requested a review from sabrinatoro as a code owner November 6, 2024 07:29
@twhetzel twhetzel assigned sabrinatoro and unassigned twhetzel Nov 6, 2024
@twhetzel
Copy link
Collaborator

twhetzel commented Nov 6, 2024

@sabrinatoro can we discuss or is there someone else that can help sort out the remaining qc issues?

@sabrinatoro sabrinatoro assigned twhetzel and unassigned sabrinatoro Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add QC check - class with excluded_subClassOf value does not also have a subClassOf statement
3 participants