Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint files to pass qc check #10

Merged
merged 3 commits into from
Mar 21, 2024
Merged

lint files to pass qc check #10

merged 3 commits into from
Mar 21, 2024

Conversation

twhetzel
Copy link
Contributor

I ran black and ruff format locally from within the repo directory to try to address the failing GH Action qc checks.

@twhetzel twhetzel self-assigned this Mar 14, 2024
@hrshdhgd
Copy link
Member

just run tox it runs both above and more

@twhetzel
Copy link
Contributor Author

twhetzel commented Mar 14, 2024

do you mean as poetry run tox -e format? this returns an error:

ROOT: HandledError| provided environments not found in configuration file:
format

Trying poetry run tox runs, but there are still linting issues found with poetry run tox -e lint

Also, the GitHub Action does not properly exclude the src/mondolib/datamodels/* directory.

@twhetzel
Copy link
Contributor Author

There still linting issues. I am not sure how to fix these. It looks like the empty line above the docstring should be removed, but when I do that it also does not pass linting.

@twhetzel twhetzel merged commit 54ccc63 into main Mar 21, 2024
3 checks passed
@twhetzel twhetzel deleted the issue-fix_linting branch March 21, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants