Refactor OWL restrictions #151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplified OWL restriction (and some evidence axiom) code by functionalizing it. - Added / updated some comments
twhetzel
reviewed
Sep 22, 2024
joeflack4
commented
Sep 22, 2024
There was a problem hiding this comment.
Which data files and example identifiers are effected by this change?
None. It would indeed be a good idea to check builds or run tests after a change like this. We can't commit and examine the files in a diff, but I can do the same procedure we did recently, running it before and after and checking the .ofn diff. I believe it is deterministic, so I would expect to see no changes. So I think I'll do that. This is low prior, so I'm gonna push it farther down my stack.
- @joeflack4 Low priority: Confirm no difference in outputs before/after this change.
There was a problem hiding this comment.
yes, i would test this to confirm everything is the same.
There was a problem hiding this comment.
without confirmation that the files are the same this should not be merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored OWL restrictions