Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Remove old resolver #1516

Merged
merged 2 commits into from
Jan 10, 2025
Merged

🧹 Remove old resolver #1516

merged 2 commits into from
Jan 10, 2025

Conversation

jaym
Copy link
Contributor

@jaym jaym commented Dec 14, 2024

This removes the old resolver and uses the rewrite everywhere.

Should fix #1515

This removes the old resolver and uses the rewrite everywhere.

Should fix #1515
@jaym jaym requested a review from arlimus December 14, 2024 11:33
Copy link
Contributor

github-actions bot commented Dec 14, 2024

Test Results

  1 files  ± 0   27 suites  ±0   1m 4s ⏱️ +4s
462 tests  - 47  461 ✅  - 47  1 💤 ±0  0 ❌ ±0 
463 runs   - 47  462 ✅  - 47  1 💤 ±0  0 ❌ ±0 

Results for commit 5a36396. ± Comparison against base commit 7940e5e.

This pull request removes 47 tests.
go.mondoo.com/cnspec/v11/policy ‑ TestResolve_CheckValidUntil
go.mondoo.com/cnspec/v11/policy ‑ TestResolve_DisabledQuery
go.mondoo.com/cnspec/v11/policy ‑ TestResolve_EmptyPolicy
go.mondoo.com/cnspec/v11/policy ‑ TestResolve_EmptyPolicy/resolve_w/o_filters
go.mondoo.com/cnspec/v11/policy ‑ TestResolve_EmptyPolicy/resolve_with_empty_filters
go.mondoo.com/cnspec/v11/policy ‑ TestResolve_EmptyPolicy/resolve_with_random_filters
go.mondoo.com/cnspec/v11/policy ‑ TestResolve_Exceptions
go.mondoo.com/cnspec/v11/policy ‑ TestResolve_Exceptions/resolve_with_disabled_control
go.mondoo.com/cnspec/v11/policy ‑ TestResolve_Exceptions/resolve_with_expired_validUntil
go.mondoo.com/cnspec/v11/policy ‑ TestResolve_Exceptions/resolve_with_ignored_control
…

♻️ This comment has been updated with latest results.

@imilchev imilchev merged commit f5aaceb into main Jan 10, 2025
15 checks passed
@imilchev imilchev deleted the jdm/remove-old-resolver branch January 10, 2025 07:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cnspec panics with props example
2 participants