Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub app auth to cnquery #453

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Add GitHub app auth to cnquery #453

merged 3 commits into from
Nov 7, 2024

Conversation

misterpantz
Copy link
Contributor

@misterpantz misterpantz commented Nov 7, 2024

Description

Need GitHub custom app auth approach for cnquery too

Related issue

none

Types of changes

  • Functional documentation bug fix (i.e., broken link or some other busted behavior)
  • New functional doc capabilities (i.e., filter search results)
  • New content
  • Revision to existing content
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist

  • I have read the README document about contributing to this repo.
  • I have tested my changes locally and there are no issues.
  • All commits are signed.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Starting creation of the PREview environment...

Copy link
Contributor

github-actions bot commented Nov 7, 2024

PREview environment has been created at https://mondoo-pre-docs-2467349816.storage.googleapis.com/docs/index.html
Please allow a few minutes for the environment to be fully deployed.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

@misterpantz misterpantz marked this pull request as ready for review November 7, 2024 18:19
Copy link
Contributor

github-actions bot commented Nov 7, 2024

@tas50 tas50 merged commit 8083bf0 into main Nov 7, 2024
8 checks passed
@tas50 tas50 deleted the misterpantz/cnquery-gh-app branch November 7, 2024 19:06
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024

11. Under **Permissions**, assign **read-only** permission to all repository and organization data.

![Permissions](/img/cnspec/github/perms.png)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this image?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duh! I missed it. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants