Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail the build on dead links #46

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Fail the build on dead links #46

merged 1 commit into from
Mar 18, 2024

Conversation

tas50
Copy link
Member

@tas50 tas50 commented Mar 15, 2024 •
edited
Loading

Description

Throw vs. warn

Related issue

N/A

Types of changes

  • Functional documentation bug fix (i.e., broken link or some other busted behavior)
  • New functional doc capabilities (i.e., filter search results)
  • New content
  • Revision to existing content
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist

  • I have read the README document about contributing to this repo.
  • I have tested my changes locally and there are no issues.
  • All commits are signed.

@tas50
Fail the build on dead links
3107003 
Throw vs. warn

Signed-off-by: Tim Smith <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

Starting creation of the PREview environment...

@github-actions GitHub Actions
Copy link
Contributor

PREview environment has been created at https://mondoo-pre-docs-3774458185.storage.googleapis.com/docs/index.html
Please allow a few minutes for the environment to be fully deployed.

@github-actions GitHub Actions
Copy link
Contributor

PREview has been updated at https://mondoo-pre-docs-3774458185.storage.googleapis.com/docs/index.html

misterpantz
misterpantz approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@misterpantz misterpantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this!

@misterpantz misterpantz merged commit b057340 into main Mar 18, 2024
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
@tas50 tas50 deleted the tas50/fail_on_dead_links branch September 6, 2024 22:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@misterpantz misterpantz misterpantz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tas50 @misterpantz