Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for the Audit Log GraphQL API #66

Merged
merged 6 commits into from
Mar 22, 2024

Conversation

benr
Copy link
Member

@benr benr commented Mar 22, 2024

Types of changes

  • Functional documentation bug fix (i.e., broken link or some other busted behavior)
  • New functional doc capabilities (i.e., filter search results)
  • New content
  • Revision to existing content
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist

  • I have read the README document about contributing to this repo.
  • I have tested my changes locally and there are no issues.
  • All commits are signed.

@benr benr self-assigned this Mar 22, 2024
Copy link
Contributor

Starting creation of the PREview environment...

Copy link
Contributor

PREview environment has been created at https://mondoo-pre-docs-1432092948.storage.googleapis.com/docs/index.html
Please allow a few minutes for the environment to be fully deployed.

@benr benr marked this pull request as draft March 22, 2024 18:26

This comment has been minimized.

benr added 2 commits March 22, 2024 11:56
Signed-off-by: Ben Rockwood <[email protected]>
Signed-off-by: Ben Rockwood <[email protected]>

This comment has been minimized.

Signed-off-by: Ben Rockwood <[email protected]>

This comment has been minimized.

Copy link
Contributor

Signed-off-by: Ben Rockwood <[email protected]>

This comment has been minimized.

Copy link
Contributor

@benr benr marked this pull request as ready for review March 22, 2024 19:30
"node": {
"identity": {
"name": "Jane Doe",
"mrn": "//captain.api.mondoo.app/users/26OR1GOGsqmfjXOOO8joxgJDdtM"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should get added to the pattern matching we already have so we don't need to put these all in the expect.txt file

Copy link
Contributor

Copy link
Contributor

@misterpantz misterpantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much, @benr!

@misterpantz misterpantz merged commit 66c62f1 into main Mar 22, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
@misterpantz misterpantz deleted the benr/audit-logs-api branch July 19, 2024 18:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants