🧹 Allow to override the API endpoint #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Fixes #9 Signed-off-by: Christian Zunker <[email protected]>
czunker
force-pushed
the
christian/set_api_endpoint
branch
from
5b61056 to
015e1cb
Compare
chris-rock
reviewed
Dec 5, 2023
gen/gen.go
Outdated
| @@ -176,10 +177,19 @@ fragment TypeRef on __Type { | |||
| } | |||
| } | |||
| ` | |||
| apiEndpoint := "https://" + apiHost + "/query" | |||
There was a problem hiding this comment.
we should define apiHost := "us.api.mondoo.com" close to this code since its otherwise difficult to read
There was a problem hiding this comment.
we should parse the url and prepend https if no schema is defined
gen/gen.go
Outdated
| apiEndpoint := "https://" + apiHost + "/query" | ||
| endpoint, ok := os.LookupEnv("MONDOO_API_ENDPOINT") | ||
| if ok { | ||
| apiEndpoint, err = url.JoinPath(endpoint, "/query") |
There was a problem hiding this comment.
we should apply that logic to the default api host too.
Signed-off-by: Christian Zunker <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9