🐛 Do not panic if service account opts error out. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preslavgerchev
force-pushed
the
preslav/no-panic
branch
from
ccc1d32 to
5ef9840
Compare
slntopp
approved these changes
Aug 12, 2024
Signed-off-by: Preslav <[email protected]>
preslavgerchev
force-pushed
the
preslav/no-panic
branch
from
5ef9840 to
17492e9
Compare
chris-rock
reviewed
Aug 12, 2024
| func WithServiceAccount(data []byte) ClientOption { | ||
| ts, sa, err := signer.NewServiceAccountTokenSource(data) | ||
| return withTokenSource{sa.ApiEndpoint, ts, err} | ||
| if err != nil { |
There was a problem hiding this comment.
I think this is ok for now. We should consider moving the parsing out and just take a the service account object directly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
NewServiceAccountTokenSourceerrs out, we get a nilsaback. Trying to accesssa.ApiEndpointcauses a panic. ReuseWithServiceAccountwhen callingWithServiceAccountFilesince the only diff is we need to read the file first in the latter.