Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: 10block old decoy vuln. disclosure #2170

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

plowsof
Copy link
Collaborator

@plowsof plowsof commented May 25, 2023

@plowsof plowsof marked this pull request as draft May 25, 2023 13:28
@netlify
Copy link

netlify bot commented May 25, 2023

Deploy Preview for barolo-time-757cf9 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5955217
🔍 Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/647f0ce01d2c3c0007574380
😎 Deploy Preview https://deploy-preview-2170--barolo-time-757cf9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@plowsof plowsof marked this pull request as ready for review May 25, 2023 13:34
@plowsof plowsof force-pushed the 10blockdisclosure branch 3 times, most recently from 064627d to bcba270 Compare May 25, 2023 15:32
@jeffro256
Copy link
Contributor

BTW, I edited the graph image in the original post to make the terminology line up better

@jeffro256
Copy link
Contributor

Do you have a specific question about the credits?

@plowsof
Copy link
Collaborator Author

plowsof commented May 26, 2023

@jeffro256 credits: just double checking that everyone involved was mentioned (i think its fine as all the PR's are listed?) and the author is "jeffro256" - do you want another handle?
Thanks for editing the image, will add. my thinking was the legend on the graph could be above or below instead of to the side (graph would get squished less)

Copy link
Contributor

@j-berman j-berman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for this @jeffro256, very much so appreciate you writing this up

_posts/2023-05-25-10block-old-decoy-selection-bug.md Outdated Show resolved Hide resolved
_posts/2023-05-25-10block-old-decoy-selection-bug.md Outdated Show resolved Hide resolved
_posts/2023-05-25-10block-old-decoy-selection-bug.md Outdated Show resolved Hide resolved
_posts/2023-05-25-10block-old-decoy-selection-bug.md Outdated Show resolved Hide resolved
_posts/2023-05-25-10block-old-decoy-selection-bug.md Outdated Show resolved Hide resolved
_posts/2023-05-25-10block-old-decoy-selection-bug.md Outdated Show resolved Hide resolved
_posts/2023-05-25-10block-old-decoy-selection-bug.md Outdated Show resolved Hide resolved
_posts/2023-05-25-10block-old-decoy-selection-bug.md Outdated Show resolved Hide resolved
_posts/2023-05-25-10block-old-decoy-selection-bug.md Outdated Show resolved Hide resolved
_posts/2023-05-25-10block-old-decoy-selection-bug.md Outdated Show resolved Hide resolved
@erciccione
Copy link
Contributor

please squash

@plowsof plowsof force-pushed the 10blockdisclosure branch 2 times, most recently from 3142f2f to 199fa89 Compare May 29, 2023 11:52
@plowsof
Copy link
Collaborator Author

plowsof commented May 29, 2023

squashed - todo: confirm the advice given by jberman to not instruct old wallet users to avoid spending 10 block old outputs (or simply delete the sentence entirely) , and fix the author of the commit to jeffro256

@jeffro256
Copy link
Contributor

I confirm that advice @plowsof

@jeffro256
Copy link
Contributor

jeffro256 commented May 30, 2023

I'll fix that graph image tonight
edit: and done

@plowsof plowsof force-pushed the 10blockdisclosure branch from c0f8ec6 to 88b07d2 Compare May 30, 2023 09:53
@plowsof
Copy link
Collaborator Author

plowsof commented May 30, 2023

thanks! added new graph, jeffro as author, and removed the old wallet suggestion.

@plowsof plowsof force-pushed the 10blockdisclosure branch from 88b07d2 to 5955217 Compare June 6, 2023 10:39
@luigi1111 luigi1111 merged commit d973dee into monero-project:master Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants