Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depends: upgrade OpenSSL to 3.0.9 #8767

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

tobtoht
Copy link
Contributor

@tobtoht tobtoht commented Mar 7, 2023

closes #8763

Overview of changes:

  • Renamed ANDROID_NDK_HOME to ANDROID_NDK_ROOT. (openssl/openssl@99ffd5a)
  • Removed no-heartbeats and no-ssl2: deprecated
  • Building tests and apps fails on ARMv8 Android due to missing includes. Updated the sed command to exclude unneeded directories to work with build.info and added no-tests.
  • OpenSSL 3.0.x writes libraries to $(host_prefix)/lib64 on x86_64-w64-mingw32, causes linking issue during unbound configure. Setting --libdir=$(host_prefix)/lib fixes the issue.
  • unbound: checking for SHA384_Init in unbound configure fails on x86_64-apple-darwin11 with
configure:20740: checking for SHA384_Init
[...]
Undefined symbols for architecture x86_64:
  "_OPENSSL_ia32cap_P", referenced from:
      _sha512_block_data_order in libcrypto.a(libcrypto-lib-sha512-x86_64.o)
ld: symbol(s) not found for architecture x86_64
clang-10: error: linker command failed with exit code 1 (use -v to see invocation)

See: https://stackoverflow.com/a/28947978 and https://boringssl.googlesource.com/boringssl/+/517073cd4b/crypto/cpu-intel.c#69. We can work around the issue by skipping the check on x86_64_darwin.

@hyc
Copy link
Collaborator

hyc commented Mar 7, 2023

Changes look sane, in a quick glance.

@tobtoht
Copy link
Contributor Author

tobtoht commented May 30, 2023

Updated to 3.0.9, which includes security fixes.

https://www.openssl.org/news/openssl-3.0-notes.html

@tobtoht tobtoht changed the title depends: upgrade OpenSSL to 3.0.8 depends: upgrade OpenSSL to 3.0.9 May 30, 2023
@luigi1111 luigi1111 merged commit 1723bba into monero-project:master Jun 27, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to OpenSSL 3.0 for release binaries
4 participants