wallet-rpc: restore from multisig seed (and fix generation) #8914

jeffro256 · 2023-06-22T13:52:08Z

If the field enable_multisig_experimental in the command restore_deterministic_wallet is set to true, monero-wallet-rpc will attempt to generate the wallet from a multisig seed instead of a normal seed, allowing the multisig wallet user to not have to resync initialization data. This multisig seed is the same data provided from query_key_info.

Edit: Also restoring from multisig seed now works when M <= N-2 and with any number of private multisig keys.

vtnerd

This multisig seed - how is it presented to the user (you can tell I've never used it before)? Possibly some confusion with the standard seed.

src/wallet/wallet_rpc_server.cpp

jeffro256 · 2023-06-24T07:31:52Z

The multisig seed can be extracted from the “seed” command in the CLI or the “query_key_info” RPC command.

jeffro256 · 2023-06-24T07:33:24Z

Yeah ”seed” could potentially be confusing since it’s not just a seed but also threshold information and signer participant configuration data.

woodser · 2023-07-10T14:49:05Z

@jeffro256 would you be able to PR this against the release branch too, so I can incorporate this change into my next release?

jeffro256 · 2023-07-10T15:00:19Z

@woodser It's open now

src/wallet/wallet_rpc_server.cpp

woodser · 2023-07-19T13:57:36Z

I'm getting errors testing restoring multisig wallets from seed.

First, successfully restored 2/2 or 2/3 multisig wallets fail on transfer or transfer_split with error "No transaction created", whereas the transaction succeeds if the wallet is not first restored from seed.

Second, 2/4 multisig wallets fail to restore at all with error: "invalid multisig seed".

woodser · 2023-07-19T14:15:15Z

Should the restoration be based on

monero/src/simplewallet/simplewallet.cpp

Line 4867 in 00fd416

    
           m_wallet->generate(m_wallet_file, std::move(rc.second).password(), multisig_keys, create_address_file);

, including restoring with a seed passphrase or offset?

jeffro256 · 2023-07-19T19:21:15Z

I'm getting errors testing restoring multisig wallets from seed.

First, successfully restored 2/2 or 2/3 multisig wallets fail on transfer or transfer_split with error "No transaction created", whereas the transaction succeeds if the wallet is not first restored from seed.

Second, 2/4 multisig wallets fail to restore at all with error: "invalid multisig seed".

The multisig seed includes configuration data so you can't change the number of participants and get a valid multisig wallet. You will need to generate a new multisig wallet for each M/N combination.

woodser · 2023-07-19T19:23:29Z

@jeffro256 Yes, these are tests for separate wallets. The M/N is never changed per wallet.

jeffro256 · 2023-07-19T19:25:35Z

Can I see the logs for the "invalid multisig seed" error? The line numbers for that error might help determine what is going on

woodser · 2023-07-19T20:02:45Z

It's thrown from here when the wallet is generated: https://github.com/monero-project/monero/blob/65035231aac56ece05302d039a718a03e58f1060/src/wallet/wallet2.cpp#L5082

Let me know if you want more log context from the key image exchange.

woodser · 2023-07-19T20:06:27Z

I'm exchanging keys N - M + 1 times here in my test, assuming that is right?

jeffro256 · 2023-07-20T00:36:52Z

It's thrown from here when the wallet is generated:

https://github.com/monero-project/monero/blob/65035231aac56ece05302d039a718a03e58f1060/src/wallet/wallet2.cpp#L5082

Let me know if you want more log context from the key image exchange.

That specific assertion is only necessary for old multisig when thresholds were limited to N/N or (N-1)/N

jeffro256 · 2023-07-20T00:37:09Z

I don't know why it's still there

jeffro256 · 2023-07-20T06:32:42Z

Okay I pushed changes to do three things: 1) In wallet2::generate() (the multisig overload), I removed the restriction for only N/N and N-1/N multisig, 2) In that same method, I changed the calculation for n_multisig_keys to factor in the size of the multisig seed data since the size of the private multisig key vector can vary based on the rounds of finalization, and 3) I removed the option to turn the multisig seed into Electrum words since the smallest possible seed (2/2) needs at least 172 words to encode it (without a checksum) and that feature was unused in the codebase.

jeffro256 · 2023-07-20T06:35:09Z

I also updated the functional tests to actually try a transfer of funds after restoring from the multisig seed

woodser · 2023-07-20T12:33:35Z

Can you also push the changes to #8942 so I can test it? Thanks.

src/wallet/wallet2.cpp

src/wallet/wallet_rpc_server.cpp

jeffro256 · 2023-07-20T18:47:02Z

src/wallet/wallet2.cpp

+// Given M (threshold) and N (total), calculate the number of private multisig keys each
+// signer should have. This value is equal to (N - 1) choose (N - M)
+// Prereq: M >= 1 && N >= M && N <= 16
+uint64_t num_priv_multisig_keys_post_setup(uint64_t threshold, uint64_t total)
+{
+  THROW_WALLET_EXCEPTION_IF(threshold < 1 || total < threshold || threshold > 16,
+    tools::error::wallet_internal_error, "Invalid arguments to num_priv_multisig_keys_post_setup");
+
+  uint64_t n_multisig_keys = 1;
+  for (uint64_t i = 2; i <= total - 1; ++i) n_multisig_keys *= i; // multiply by (N - 1)!
+  for (uint64_t i = 2; i <= total - threshold; ++i) n_multisig_keys /= i; // divide by (N - M)!
+  for (uint64_t i = 2; i <= threshold - 1; ++i) n_multisig_keys /= i; // divide by ((N - 1) - (N - M))!
+  return n_multisig_keys;
+}


@UkoeHB This formula appears to work correctly to calculate the number of private multisig keys per signer, thanks!

jeffro256 · 2023-07-20T18:48:27Z

tests/functional_tests/multisig.py

+    def remake_some_multisig_wallets_by_multsig_seed(self, threshold):
+      N = len(self.wallet)
+      signers_to_remake = set()
+      num_signers_to_remake = random.randint(1, N) # Do at least one
+      while len(signers_to_remake) < num_signers_to_remake:
+        signers_to_remake.add(random.randint(0, N - 1))


I changed the function to restore some not all multisig wallets in case bugs would arise when a seed-restored interacted w/ a normal wallet.

jeffro256 · 2023-07-20T18:49:18Z

tests/functional_tests/multisig.py

+        self.create_multisig_wallets(1, 2, '4A8RnBQixry4VXkqeWhmg8L7vWJVDJj4FN9PV4E7Mgad5ZZ6LKQdn8dYJP2RePX6HMaSkbvTbrWUFhDNcNcHgtNmQ4S8RSB')
+        self.import_multisig_info([0, 1], 5)
+        txid = self.transfer([0])
+        self.import_multisig_info([0, 1], 6)
+        self.check_transaction(txid)


I added a test case for a 1/2 multisig wallet since none of the cases yet have 1 as the threshold

woodser · 2023-07-20T20:32:53Z

With the latest push to the release branch, 2/4 multisig wallets are restoring successfully.

However, calling transfer or transfer_split after restoring any multisig wallet still gives the error "No transaction created". Hopefully this is reproducible in the unit tests.

It works as expected without restoring the multisig wallet from seed.

src/wallet/wallet_rpc_server.cpp

selsta · 2023-08-01T23:49:17Z

@woodser are all your issues resolved?

woodser · 2023-08-02T10:51:50Z

@selsta No this isn't resolved yet; still waiting for a fix to the "No transactions created" error after restoring from seed.

jeffro256 · 2023-08-10T04:41:25Z

So I took the time to setup the monero-java JUnit tests using the PR branch that @woodser was using using a patched (with this PR) wallet rpc server. What I found was that the "no transactions created" error for me was 1) temporary and 2) affected both restoring with multisig seed and not restoring. I think that there might be a race condition in tests somewhere that is exacerbated by restoring by seed since the cache is flushed, but I have not been able to reliably reproduce this error; the test cases usually passes for me when restoring from multisig seed.

woodser · 2023-08-10T12:16:15Z

After some digging based on @jeffro256 's comment, I found a bug in the Java tests when restoring from seed, where the keys were not being exchanged correctly (fixed in woodser/monero-java@13004cc).

It's working now with that fix. :)

The changes to the multisig tests in monero-project#8914 and monero-project#8904 affected each other, this PR cleans up the code and fixes that issue.

vtnerd reviewed Jun 23, 2023

View reviewed changes

src/wallet/wallet_rpc_server.cpp Outdated Show resolved Hide resolved

jeffro256 changed the title ~~wallet-rpc: restore from multisig keys feature~~ wallet-rpc: restore from multisig seed feature Jun 24, 2023

jeffro256 force-pushed the restore_multisig_seed_rpc branch from 0a39763 to 0400c16 Compare June 24, 2023 21:02

vtnerd approved these changes Jun 27, 2023

View reviewed changes

jeffro256 mentioned this pull request Jul 10, 2023

wallet-rpc: restore from multisig seed (and fix generation) [RELEASE] #8942

Merged

woodser reviewed Jul 18, 2023

View reviewed changes

src/wallet/wallet_rpc_server.cpp Show resolved Hide resolved

jeffro256 force-pushed the restore_multisig_seed_rpc branch from 0400c16 to 91c7726 Compare July 18, 2023 20:23

jeffro256 force-pushed the restore_multisig_seed_rpc branch from 91c7726 to cb668ab Compare July 20, 2023 06:28

jeffro256 changed the title ~~wallet-rpc: restore from multisig seed feature~~ wallet-rpc: restore from multisig seed (and fix generation) Jul 20, 2023

UkoeHB reviewed Jul 20, 2023

View reviewed changes

src/wallet/wallet2.cpp Outdated Show resolved Hide resolved

src/wallet/wallet2.cpp Outdated Show resolved Hide resolved

src/wallet/wallet_rpc_server.cpp Show resolved Hide resolved

jeffro256 force-pushed the restore_multisig_seed_rpc branch from cb668ab to cbc4acc Compare July 20, 2023 18:44

jeffro256 commented Jul 20, 2023

View reviewed changes

jeffro256 force-pushed the restore_multisig_seed_rpc branch from cbc4acc to 10ec710 Compare July 20, 2023 19:30

jeffro256 force-pushed the restore_multisig_seed_rpc branch from 10ec710 to 34f935d Compare July 23, 2023 05:00

woodser reviewed Jul 24, 2023

View reviewed changes

src/wallet/wallet_rpc_server.cpp Show resolved Hide resolved

wallet-rpc: restore from multisig seed

45b52de

jeffro256 force-pushed the restore_multisig_seed_rpc branch from 34f935d to 45b52de Compare July 28, 2023 17:17

selsta approved these changes Aug 10, 2023

View reviewed changes

luigi1111 merged commit 3b67d5f into monero-project:master Aug 17, 2023
17 of 18 checks passed

jeffro256 mentioned this pull request Aug 20, 2023

functional_tests: fix multisig tests noutputs assertion #8976

Merged

jeffro256 deleted the restore_multisig_seed_rpc branch August 20, 2023 03:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

wallet-rpc: restore from multisig seed (and fix generation) #8914

wallet-rpc: restore from multisig seed (and fix generation) #8914

jeffro256 commented Jun 22, 2023 •

edited

Loading

vtnerd left a comment

jeffro256 commented Jun 24, 2023

jeffro256 commented Jun 24, 2023

woodser commented Jul 10, 2023

jeffro256 commented Jul 10, 2023

woodser commented Jul 19, 2023

woodser commented Jul 19, 2023

jeffro256 commented Jul 19, 2023

woodser commented Jul 19, 2023

jeffro256 commented Jul 19, 2023

woodser commented Jul 19, 2023 •

edited

Loading

woodser commented Jul 19, 2023

jeffro256 commented Jul 20, 2023

jeffro256 commented Jul 20, 2023

jeffro256 commented Jul 20, 2023

jeffro256 commented Jul 20, 2023

woodser commented Jul 20, 2023 •

edited

Loading

jeffro256 Jul 20, 2023

jeffro256 Jul 20, 2023

jeffro256 Jul 20, 2023

woodser commented Jul 20, 2023

selsta commented Aug 1, 2023

woodser commented Aug 2, 2023

jeffro256 commented Aug 10, 2023

woodser commented Aug 10, 2023

wallet-rpc: restore from multisig seed (and fix generation) #8914

wallet-rpc: restore from multisig seed (and fix generation) #8914

Conversation

jeffro256 commented Jun 22, 2023 • edited Loading

vtnerd left a comment

Choose a reason for hiding this comment

jeffro256 commented Jun 24, 2023

jeffro256 commented Jun 24, 2023

woodser commented Jul 10, 2023

jeffro256 commented Jul 10, 2023

woodser commented Jul 19, 2023

woodser commented Jul 19, 2023

jeffro256 commented Jul 19, 2023

woodser commented Jul 19, 2023

jeffro256 commented Jul 19, 2023

woodser commented Jul 19, 2023 • edited Loading

woodser commented Jul 19, 2023

jeffro256 commented Jul 20, 2023

jeffro256 commented Jul 20, 2023

jeffro256 commented Jul 20, 2023

jeffro256 commented Jul 20, 2023

woodser commented Jul 20, 2023 • edited Loading

jeffro256 Jul 20, 2023

Choose a reason for hiding this comment

jeffro256 Jul 20, 2023

Choose a reason for hiding this comment

jeffro256 Jul 20, 2023

Choose a reason for hiding this comment

woodser commented Jul 20, 2023

selsta commented Aug 1, 2023

woodser commented Aug 2, 2023

jeffro256 commented Aug 10, 2023

woodser commented Aug 10, 2023

jeffro256 commented Jun 22, 2023 •

edited

Loading

woodser commented Jul 19, 2023 •

edited

Loading

woodser commented Jul 20, 2023 •

edited

Loading