Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of CMakeLists.txt files with absolute installation paths like:
install(TARGETS wallet_rpc_server DESTINATION bin)
where
bin
usually points to/usr/local/bin
.It works well, but if some build system attempts to produce a package, it will fail since a user might not have root privileges. Such build systems usually place artifacts in a dedicated directory, like
~/my-package/usr/local/bin/
. As an example, FreeBSD's Makefile and Poudriere always fail during the insufficient access rights. I believe this is not the only case.So I just changed the install paths to respect CMake prefixes according to CMake documentation:
install(TARGETS wallet_rpc_server DESTINATION ${CMAKE_INSTALL_BINDIR})
And now the produced executables and libraries can be placed to the right directory.