cryptonote_core: unrestricted rpc to respect packet size limit #9473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xFFFC0000
changed the title
|
Windows build failure is unrelated to this PR: Mac build failure is unrelated to this PR and related to |
Co-authored-by: jeffro256 <[email protected]>
0xFFFC0000
force-pushed
the
dev/0xfffc/fix-rpc-limit
branch
from
c0e536c
to
32ccf2a
Compare
|
Fix all the issues raised here [1]. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When txpool is greater than 100mb, unrestricted rpc cannot connect. Restricted rpc remains functional due to batching into 100tx per call. Here, were batching into 90% of the packet size limit